Re: [PATCH 1/5] mm: compaction: push watermark into compaction_suitable() callers

From: Hugh Dickins
Date: Sun Mar 16 2025 - 00:28:41 EST


[PATCH] mm: compaction: push watermark into compaction_suitable() callers fix

Stop oops on out-of-range highest_zoneidx: compaction_suitable() pass
args to __compaction_suitable() in the order which it is expecting.

Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 4a2ccb82d0b2..b5c9e8fd39f1 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2433,7 +2433,7 @@ bool compaction_suitable(struct zone *zone, int order, unsigned long watermark,
enum compact_result compact_result;
bool suitable;

- suitable = __compaction_suitable(zone, order, highest_zoneidx, watermark,
+ suitable = __compaction_suitable(zone, order, watermark, highest_zoneidx,
zone_page_state(zone, NR_FREE_PAGES));
/*
* fragmentation index determines if allocation failures are due to
--
2.43.0