Re: [PATCH v2 5/5] arm: dts: bcm2711-rpi: Add HEVC decoder node

[Stefan Wahren]

Hi Dave,

Am 06.02.25 um 19:02 schrieb Dave Stevenson:
> Add the configuration information for the HEVC decoder.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> ---
>   arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi | 4 ++++
>   arch/arm/boot/dts/broadcom/bcm2711.dtsi     | 9 +++++++++
>   2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi b/arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi
> index 6bf4241fe3b7..56c633005941 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi
> @@ -105,3 +105,7 @@ &vchiq {
>   &xhci {
>   	power-domains = <&power RPI_POWER_DOMAIN_USB>;
>   };
> +
> +&hevc_dec {
> +	clocks = <&firmware_clocks 11>;
> +};
the node ref should be in alphabetical order, so please add after hdmi1.
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> index e4e42af21ef3..2931d93ba184 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> @@ -628,6 +628,15 @@ v3d: gpu@7ec00000 {
>   			resets = <&pm BCM2835_RESET_V3D>;
>   			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
>   		};
> +
> +		hevc_dec: codec@7eb10000 {
Please put the node before V3D to keep the register order.
> +			compatible = "raspberrypi,hevc-dec";
> +			reg = <0x0 0x7eb00000  0x10000>, /* HEVC */
> +			      <0x0 0x7eb10000  0x1000>;  /* INTC */
Since the reg-names are provided, there is no need for these comments.
> +			reg-names = "hevc",
> +				    "intc";
> +			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> +		};
>   	};
>   };