Re: [PATCH] x86/asm: Use asm_inline() instead of asm() in amd_clear_divider()

From: Borislav Petkov
Date: Sun Mar 16 2025 - 06:53:53 EST


On Sun, Mar 16, 2025 at 01:37:23AM +0100, Ingo Molnar wrote:
> Yeah, so that's a suboptimal test for these particular changes really:
> why would a simple CPU-saturated kernel build with low levels of kernel
> use of the affected areas show measurable changes with this commit?

Thus "Or maybe I need a different benchmark." :)

OTOH, it still tells me that if there are no negative changes in *that*
benchmark, then I should not worry.

> So on my system there appears to be a measurable improvement in
> performance on this particular benchmark on the order of magnitude of
> around ~0.8%, which is outside the measurement noise of around ~0.2%.

That's fine. It won't make me fall off my horse but sure, there are some small
improvements. Just don't let code readability suffer along the way with those
exercises.

:-)

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette