Re: [PATCH v4 2/3] arm64: dts: amlogic: Add A4 Reset Controller

[Kelvin Zhang]

On 2025/3/14 16:01, Krzysztof Kozlowski wrote:
> On Thu, Mar 13, 2025 at 05:05:35PM +0800, Kelvin Zhang wrote:
> >   &apb {
> > +     reset: reset-controller@2000 {
> > +             compatible = "amlogic,a4-reset",
> > +                          "amlogic,meson-s4-reset";
> > +             reg = <0x0 0x2000 0x0 0x98>;
> > +             #reset-cells = <1>;
> > +     };
> > +
>
> Why do you have on the bus devices with bus addressing and without it?
> What sort of bus is it?

Are you referring to the 'apb'?
If so, the 'apb' bus is defined in 
arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi.

apb: bus@fe000000 {
        compatible = "simple-bus";
        reg = <0x0 0xfe000000 0x0 0x480000>;
        #address-cells = <2>;
        #size-cells = <2>;
        ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;

> >        periphs_pinctrl: pinctrl {
> >                compatible = "amlogic,pinctrl-a4";
> >                #address-cells = <2>;
>
> Best regards,
> Krzysztof

--
Best regards,

Kelvin Zhang