Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()

[feng.wei8]

I see the following commit：

|https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb

I don't think code optimization and unification is "garbage". If so, why did you choose to merge into a commit like "garbage".
I'm just bothered by this aspect when I usually look at the code, so why not be concise.
I would even like to implement `min4/max4` like `dml_min4/dml_max4`. Wouldn't that be more concise code?

As a newcomer, my perspectives may differ from those of the experts here. I apologize if this has caused any inconvenience.

Thanks

Original

From: johannes <johannes@xxxxxxxxxxxxxxxx>

To: Feng Wei10332721;linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>;

Cc: linux-wireless <linux-wireless@xxxxxxxxxxxxxxx>;

Date: 2025/03/16 22:01

Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()

Please do not send utter garbage patches. It wastes everyone's time.

If you don't know what you're doing, just stop. There's very very little
value in such patches anyway, so don't send them. First think if it
actually does something useful, and if in doubt, don't.

johannes