Re: [PATCH linux-next] params: use sysfs_emit() instead of scnprintf().

[Jiri Slaby]

On 15. 03. 25, 7:17, xie.ludan@xxxxxxxxxx wrote:
> From: XieLudan <xie.ludan@xxxxxxxxxx>
>
>
> Follow the advice in Documentation/filesystems/sysfs.rst:
>
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
>
> the value to be returned to user space.
>
>
> Signed-off-by: XieLudan <xie.ludan@xxxxxxxxxx>
>
> ---
>
>   kernel/params.c | 8 ++++----
>
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
>
> diff --git a/kernel/params.c b/kernel/params.c
>
> index 2509f216c9f3..89ae571af266 100644
>
> --- a/kernel/params.c
>
> +++ b/kernel/params.c
>
> @@ -219,7 +219,7 @@ char *parse_args(const char *doing,
>
> }\
>
> int param_get_##name(char *buffer, const struct kernel_param *kp) \
>
> {\
>
> -return scnprintf(buffer, PAGE_SIZE, format "\n",\
>
> +return sysfs_emit(buffer, format "\n",\

This has nothing to do with sysfs, right?

--
js
suse labs