Re: [PATCH v6 06/10] dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller

From: Taniya Das
Date: Mon Mar 17 2025 - 02:36:35 EST




On 3/14/2025 4:47 AM, Bjorn Andersson wrote:
> On Thu, Mar 13, 2025 at 02:18:57PM +0530, Taniya Das wrote:
>>
>>
>> On 3/13/2025 1:54 PM, Krzysztof Kozlowski wrote:
>>> On Thu, Mar 13, 2025 at 12:29:43PM +0530, Taniya Das wrote:
>>> +
>>>> + '#reset-cells':
>>>> + const: 1
>>>> +
>>>> + '#power-domain-cells':
>>>> + const: 1
>>>> +
>>>> +required:
>>>> + - compatible
>>>> + - reg
>>>> + - clocks
>>>> + - '#clock-cells'
>>>> + - '#reset-cells'
>>>> + - '#power-domain-cells'
>>>> +
>>>
>>> I don't get why this binding is different than others and you do not
>>> reference qcom,gcc.yaml? Is it not applicable here? Other gpucc do
>>> reference.
>>>
>>
>> Yes, I will fix them and resend.
>>
>
> What is it that you will fix and resend? This patch or all other cases?
>
> Please stop just throwing stuff at the list and until something sticks,
> talk with the people who review your patches.
>

Bjorn, I will fix all of them in the series and send out.

> Regards,
> Bjorn
>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>