Re: [PATCH linux-next] genirq: use sysfs_emit() instead of scnprintf().

[Jiri Slaby]

On 17. 03. 25, 7:27, xie.ludan@xxxxxxxxxx wrote:
> Date: Fri, 14 Mar 2025 12:05:36 +0800
>
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>
> Signed-off-by: XieLudan <xie.ludan@xxxxxxxxxx>

I point you to study Documentation/process/submitting-patches.rst first.

In particular, I am missing versioning and versionlog.

I would also appreciate being CCed on next versions of patches I am 
reviewing.

> --- a/kernel/irq/irqdesc.c
> +++ b/kernel/irq/irqdesc.c
> @@ -257,11 +257,11 @@ static ssize_t per_cpu_count_show(struct kobject *kobj,
>   	for_each_possible_cpu(cpu) {
>   		unsigned int c = irq_desc_kstat_cpu(desc, cpu);
>
> -		ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%s%u", p, c);
> +		ret += sysfs_emit(buf + ret, "%s%u", p, c);

Sadly, the more important concern I had remained.

regards,
--
js
suse labs