Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()

[Johannes Berg]

On Mon, 2025-03-17 at 09:30 +0100, Krzysztof Kozlowski wrote:
> 
> > +++ b/net/mac80211/rc80211_minstrel_ht.c
> > @@ -1010,7 +1010,7 @@ minstrel_ht_refill_sample_rates(struct minstrel_ht_sta *mi)
> >  	u32 prob_dur = minstrel_get_duration(mi->max_prob_rate);
> >  	u32 tp_dur = minstrel_get_duration(mi->max_tp_rate[0]);
> >  	u32 tp2_dur = minstrel_get_duration(mi->max_tp_rate[1]);
> > -	u32 fast_rate_dur = min(tp_dur, tp2_dur, prob_dur);
> > +	u32 fast_rate_dur = min3(tp_dur, tp2_dur, prob_dur);
> 
> This is automation-generated junk code. How does it "simplify the
> statement"?

It's worse. The "minus" code doesn't even exist upstream.

> Can ZTE slow down this flood of automation or research experiment on
> kernel community?

Please.

johannes