Re: [PATCH v4 1/9] sched: Add a generic function to return the preemption string.

[Ingo Molnar]

* Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote:

> On 2025-03-16 12:15:47 [+0100], Ingo Molnar wrote:
> > 
> > * Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote:
> > 
> > > +const char *preempt_modes[] = {
> > > +	"none", "voluntary", "full", "lazy", NULL,
> > > +};
> > 
> > > +	/* Count entries in NULL terminated preempt_modes */
> > > +	for (j = 0; preempt_modes[j]; j++)
> > > +		;
> > 
> > I'm pretty sure the build-time ARRAY_SIZE() primitive is superior here. ;-)
> 
> It would be but it is not an option.
> That array is defined in core.c where it is "always" required while
> debug.c needs it optionally. core.c is its one compile unit while
> debug.c is included by build_utility.c. So I don't see how this can work
> unless we shift things:

Why not have it all in debug.c?

Thanks,

	Ingo