Re: [PATCH 03/13] objtool: Improve __noreturn annotation warning
From: Miroslav Benes
Date: Mon Mar 17 2025 - 06:43:13 EST
On Mon, 17 Mar 2025, Brendan Jackman wrote:
> On Fri, Mar 14, 2025 at 12:29:01PM -0700, Josh Poimboeuf wrote:
> > Clarify what needs to be done to resolve the missing __noreturn warning.
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > ---
> > tools/objtool/Documentation/objtool.txt | 12 +++++-------
> > tools/objtool/check.c | 2 +-
> > 2 files changed, 6 insertions(+), 8 deletions(-)
> >
> > diff --git a/tools/objtool/Documentation/objtool.txt b/tools/objtool/Documentation/objtool.txt
> > index 7c3ee959b63c..87950a7aaa17 100644
> > --- a/tools/objtool/Documentation/objtool.txt
> > +++ b/tools/objtool/Documentation/objtool.txt
> > @@ -319,14 +319,12 @@ the objtool maintainers.
> > a just a bad person, you can tell objtool to ignore it. See the
> > "Adding exceptions" section below.
> >
> > - If it's not actually in a callable function (e.g. kernel entry code),
> > - change ENDPROC to END.
>
> Did you mean to delete that?
I would say so but it should go to the next patch 4/13 alongside the other
doc updates.
Miroslav