Re: [PATCH v2 17/31] tty: mmc: sdio: use bool for cts and remove parentheses

[Ulf Hansson]

On Mon, 17 Mar 2025 at 08:01, Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> wrote:
>
> 'cts' in sdio_uart_check_modem_status() is considered a 'bool', but
> typed as signed 'int'. Make it 'bool' so it is clear the code does not
> care about the masked value, but true/false.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/sdio_uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/sdio_uart.c b/drivers/mmc/core/sdio_uart.c
> index 6b7471dba3bf..7423a601e1e5 100644
> --- a/drivers/mmc/core/sdio_uart.c
> +++ b/drivers/mmc/core/sdio_uart.c
> @@ -471,7 +471,7 @@ static void sdio_uart_check_modem_status(struct sdio_uart_port *port)
>                 port->icount.cts++;
>                 tty = tty_port_tty_get(&port->port);
>                 if (tty && C_CRTSCTS(tty)) {
> -                       int cts = (status & UART_MSR_CTS);
> +                       bool cts = status & UART_MSR_CTS;
>                         if (tty->hw_stopped) {
>                                 if (cts) {
>                                         tty->hw_stopped = false;
> --
> 2.49.0
>