Re: [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally

From: Yixun Lan
Date: Mon Mar 17 2025 - 09:23:23 EST


Hi Linus Walleij:

Can you also take this? thanks

On 09:06 Mon 17 Mar , Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional
> functionality.
>
> Fixes: 7ff4faba63571c51 ("pinctrl: spacemit: enable config option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Yixun Lan <dlan@xxxxxxxxxx>

> ---
> drivers/pinctrl/spacemit/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> index a2f98b3f8a75580d..d6f6017fd097d326 100644
> --- a/drivers/pinctrl/spacemit/Kconfig
> +++ b/drivers/pinctrl/spacemit/Kconfig
> @@ -7,7 +7,7 @@ config PINCTRL_SPACEMIT_K1
> bool "SpacemiT K1 SoC Pinctrl driver"
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on OF
> - default y
> + default ARCH_SPACEMIT
> select GENERIC_PINCTRL_GROUPS
> select GENERIC_PINMUX_FUNCTIONS
> select GENERIC_PINCONF
> --
> 2.43.0
>

--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55