Re: [PATCH 9/9] regulator: dummy: convert to use the faux device interface

From: Sudeep Holla
Date: Mon Mar 17 2025 - 10:30:32 EST


On Mon, Mar 17, 2025 at 03:26:00PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Mar 17, 2025 at 02:13:49PM +0000, Sudeep Holla wrote:
> > On Mon, Mar 17, 2025 at 02:00:04PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Mar 17, 2025 at 10:13:21AM +0000, Sudeep Holla wrote:
> > > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > >
> > > Why are you resending my patch back to me?
> > >
> > > > The dummy regulator driver does not need to create a platform device, it
> > > > only did so because it was simple to do. Change it over to use the
> > > > faux bus instead as this is NOT a real platform device, and it makes
> > > > the code even smaller than before.
> > > >
> > > > Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
> > > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > Message-Id: <2025021027-outclass-stress-59dd@gregkh>
> > > > (sudeep.holla: Made dummy_regulator_driver static)
> > >
> > > So this is a new version?
> > >
> >
> > Not really, I pulled your patch as I needed that as well to clean out
> > all faux device out of platform. I just made dummy_regulator_driver
> > static back again as compiler was warning. Definitely nothing new.
> > I will drop it when posting v2. You can probably fix up to make
> > dummy_regulator_driver static.
>
> My tree can't be rebased, can you just send a patch to make that change
> instead?
>

Sure, will do that.

--
Regards,
Sudeep