Re: [PATCH v1 2/2] ARM: tegra: Add device-tree for ASUS Transformer Pad LTE TF300TL

[Krzysztof Kozlowski]

On 17/03/2025 12:19, Svyatoslav Ryhel wrote:
> пн, 17 бер. 2025 р. о 13:04 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
>>
>> On Sat, Mar 15, 2025 at 09:44:16AM +0200, Svyatoslav Ryhel wrote:
>>> +#include "tegra30-asus-transformer-common.dtsi"
>>> +#include "tegra30-asus-lvds-display.dtsi"
>>> +
>>> +/ {
>>> +     model = "Asus Transformer Pad LTE TF300TL";
>>> +     compatible = "asus,tf300tl", "nvidia,tegra30";
>>> +
>>> +     gpio@6000d000 {
>>> +             tf300tl-init-hog {
>>> +                     gpio-hog;
>>> +                     gpios = <TEGRA_GPIO(C, 6) GPIO_ACTIVE_HIGH>;
>>> +                     output-low;
>>> +             };
>>> +     };
>>> +
>>> +     pinmux@70000868 {
>>> +             state_default: pinmux {
>>> +                     lcd_pwr2_pc6 {
>>
>> No underscores in node names.
>>
> 
> These bindings overwrite bindings in the common pinmux configuration
> which has names with underscores, so underscores are needed for
> correct configuration.

Ack, this Tegra coding style will make big even such trivial fixup...

Best regards,
Krzysztof