Re: [PATCH v7 1/6] dt-bindings: iio: filter: Add lpf/hpf freq margins
From: Sam Winchenbach
Date: Mon Mar 17 2025 - 11:08:46 EST
On Sun, Mar 16, 2025 at 05:38:42PM +0100, Krzysztof Kozlowski wrote:
> On Sun, Mar 16, 2025 at 09:50:03AM -0400, Sam Winchenbach wrote:
> > From: Sam Winchenbach <swinchenbach@xxxxxxxx>
> >
> > Adds two properties to add a margin when automatically finding the
> > corner frequencies.
> >
> > Signed-off-by: Sam Winchenbach <swinchenbach@xxxxxxxx>
> > ---
> > .../bindings/iio/filter/adi,admv8818.yaml | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
>
> I don't understand. You got my tag. No changelog here, no cover letter,
> nothing explains what happened here and why the tag is being removed.
>
Apologies,
I am still quite new to this workflow, and it deviates significantly
from my day-to-day work. I mentioned in the previous patch set that I
would like to update my email address and change:
"driver core: -> iio: core:"
I wasn't aware more than that was needed. Sorry for any confusion
this may have caused.
In the future what is the preferred way to handle a
situation like this? I wasn't aware of the cover letter feature but
that looks like a promising option.
It looks like another option is to add commentary to each patch.
I am less certain about your tag being removed - I don't fully
understand that. Is there a way to preserve that if changes are made
after you sign-off?
Sorry again about the confusion this caused,
-Sam
> Best regards,
> Krzysztof
>