RE: [PATCH v3 1/6] soc: renesas: rz-sysc: add syscon/regmap support

[John Madieu]

Hi Geert,

Thanks for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Monday, March 17, 2025 4:13 PM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v3 1/6] soc: renesas: rz-sysc: add syscon/regmap
> support
> 
> On Sat, 15 Mar 2025 at 09:12, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > The RZ/G3E system controller has various registers that control or
> > report some properties specific to individual IPs. The regmap is
> > registered as a syscon device to allow these IP drivers to access the
> > registers through the regmap API.
> >
> > As other RZ SoCs might have custom read/write callbacks or
> > max-offsets, let's register a custom regmap configuration.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> 
> > --- a/drivers/soc/renesas/rz-sysc.c
> > +++ b/drivers/soc/renesas/rz-sysc.c
> > @@ -6,8 +6,10 @@
> >   */
> >
> >  #include <linux/io.h>
> > +#include <linux/mfd/syscon.h>
> >  #include <linux/of.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/regmap.h>
> >  #include <linux/sys_soc.h>
> >
> >  #include "rz-sysc.h"
> > @@ -81,6 +83,14 @@ static int rz_sysc_soc_init(struct rz_sysc *sysc,
> const struct of_device_id *mat
> >         return 0;
> >  }
> >
> > +static struct regmap_config rz_sysc_regmap = {
> 
> WARNING: struct regmap_config should normally be const

I'll queue the fix for next version.

> 
> Aborting review, new version has been posted...

Sorry for that. Since this file (and other .c files) received no
review from v1, I was thinking they all depend on the YAML file
acceptation, that's why I immediately sent v4 series.

I'll wait for feedback not only based on YAML file on v4 before
posting anything new.


> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

Regards,
John