Re: [PATCH v3 1/2] kunit: tool: Fix bug in parsing test plan

From: Brendan Jackman
Date: Mon Mar 17 2025 - 12:14:35 EST


On Fri, 14 Mar 2025 at 06:37, David Gow <davidgow@xxxxxxxxxx> wrote:
>
> On Fri, 14 Mar 2025 at 03:27, Rae Moar <rmoar@xxxxxxxxxx> wrote:
> >
> > A bug was identified where the KTAP below caused an infinite loop:
> >
> > TAP version 13
> > ok 4 test_case
> > 1..4
> >
> > The infinite loop was caused by the parser not parsing a test plan
> > if following a test result line.
> >
> > Fix this bug by parsing test plan line to avoid the infinite loop.

Hi Rae,

With this change and this input:

https://gist.githubusercontent.com/bjackman/220265699f346e16161c6534b115019b/raw/a2e0e1aa75c0d8ab9814708b028ec78810a0471b/run_vmtests.sh.tap

The infinite loop is gone, but it's still hallucinating a [CRASHED] result:

[16:07:15] # SUMMARY: PASS=17 SKIP=0 FAIL=1
[16:07:15] [CRASHED]
...
[16:07:15] Testing complete. Ran 19 tests: passed: 17, failed: 1, crashed: 1