Re: [PATCH v3 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on disconnect

[Maxime Ripard]

On Mon, Mar 17, 2025 at 02:37:03PM +0000, David Turner wrote:
> Hi Maxime,
> 
> Thanks for the reviews.
> 
> On Fri, 14 Mar 2025 at 13:33, Maxime Ripard <mripard@xxxxxxxxxx> wrote:
> > I also think that it's wrong, it's not just about audio. It just needs
> > to be called as part of detect no matter what the status is. Audio is
> > one thing that it will possibly handle depending on the driver, but
> > EDIDs, CEC, etc. might also be dealt with. So I don't think it's right
> > to focus on audio there.
> 
> Does this wording sound ok?
> 
>  * This function should be called as a part of the .detect() / .detect_ctx()
>  * callbacks for all status changes in order to update the HDMI-specific
>  * connector's data.

I'd drop everything after "in order to..." but yeah, it's much better, thanks!
Maxime

Attachment: signature.asc
Description: PGP signature