Re: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset()
From: Mark Brown
Date: Mon Mar 17 2025 - 12:55:10 EST
On Mon, Mar 17, 2025 at 08:44:01AM -0700, Breno Leitao wrote:
> My UEFI machines with tegra210-quad consistently report "device reset
> failed". Investigation showed this isn't an actual failure
> - __device_reset() returns -ENOENT because ACPI has no "*_RST" method.
That's not the case, it's returning an error because there is no reset
controller discoverable via any mechanism. There's no specific handling
for ACPI here. It's also not clear that this is a false positive, the
driver did indeed fail to reset the device and especially for the error
handling case that seems like relevant information. At the very least
the changelog should be clarified.
Attachment:
signature.asc
Description: PGP signature