Re: [PATCH 1/1 next] tools build: Remove the libunwind feature tests from the ones detected when test-all.o builds

[Namhyung Kim]

Hello,

On Mon, Mar 17, 2025 at 09:10:29AM -0700, Ian Rogers wrote:
> On Wed, Dec 11, 2024 at 7:45 AM Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> >
> > We have a tools/build/feature/test-all.c that has the most common set of
> > features that perf uses and are expected to have its development files
> > available when building perf.
> >
> > When we made libwunwind opt-in we forgot to remove them from the list of
> > features that are assumed to be available when test-all.c builds, remove
> > them.
> >
> > Before this patch:
> >
> >   $ rm -rf /tmp/b ; mkdir /tmp/b ; make -C tools/perf O=/tmp/b feature-dump ; grep feature-libunwind-aarch64= /tmp/b/FEATURE-DUMP
> >   feature-libunwind-aarch64=1
> >   $
> >
> > Even tho this not being test built and those header files being
> > available:
> >
> >   $ head -5 tools/build/feature/test-libunwind-aarch64.c
> >   // SPDX-License-Identifier: GPL-2.0
> >   #include <libunwind-aarch64.h>
> >   #include <stdlib.h>
> >
> >   extern int UNW_OBJ(dwarf_search_unwind_table) (unw_addr_space_t as,
> >   $
> >
> > After this patch:
> >
> >   $ grep feature-libunwind- /tmp/b/FEATURE-DUMP
> >   $
> >
> > Now an audit on what is being enabled when test-all.c builds will be
> > performed.
> >
> > Fixes: 176c9d1e6a06f2fa ("tools features: Don't check for libunwind devel files by default")
> > Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Cc: Ian Rogers <irogers@xxxxxxxxxx>
> > Cc: James Clark <james.clark@xxxxxxxxxx>
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> 
> Sorry for the delay on this.
> 
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks for the review, but I think this part is used by other tools like
BPF and tracing.  It'd be nice to get reviews from them.

Thanks,
Namhyung

> 
> > ---
> >  tools/build/Makefile.feature | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > index b2884bc23775e986..9cde51104c2d70ec 100644
> > --- a/tools/build/Makefile.feature
> > +++ b/tools/build/Makefile.feature
> > @@ -90,13 +90,6 @@ FEATURE_TESTS_EXTRA :=                  \
> >           libbfd-liberty                 \
> >           libbfd-liberty-z               \
> >           libopencsd                     \
> > -         libunwind-x86                  \
> > -         libunwind-x86_64               \
> > -         libunwind-arm                  \
> > -         libunwind-aarch64              \
> > -         libunwind-debug-frame          \
> > -         libunwind-debug-frame-arm      \
> > -         libunwind-debug-frame-aarch64  \
> >           cxx                            \
> >           llvm                           \
> >           clang                          \
> > --
> > 2.47.0
> >