Re: [net-next PATCH v2] octeontx2-af: fix build warnings flagged by clang, sparse ,kernel test robot
From: Simon Horman
Date: Mon Mar 17 2025 - 13:09:59 EST
On Tue, Mar 11, 2025 at 08:57:22AM +0000, Sai Krishna Gajula wrote:
...
> > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > index cd0d7b7774f1..c850ea5d1960 100644
> > > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
> > > @@ -591,7 +591,7 @@ static void rvu_check_min_msix_vec(struct rvu
> > > *rvu, int nvecs, int pf, int vf)
> > >
> > > check_pf:
> > > if (pf == 0)
> > > - min_vecs = RVU_AF_INT_VEC_CNT + RVU_PF_INT_VEC_CNT;
> > > + min_vecs = (int)RVU_AF_INT_VEC_CNT +
> > (int)RVU_PF_INT_VEC_CNT;
> > > else
> > > min_vecs = RVU_PF_INT_VEC_CNT;
> > >
> >
> > I think that in the light of Linus's feedback and the subsequent patch that
> > demoted -Wenum-enum-conversion from W=1 to W=1 this is not necessary.
>
> Ack, will ignore these changes which are flagged by -Wenum-enum-conversion
Thanks,
FTR this should have read "from W=1 to W=2"
...