Re: [PATCH] drop_caches: Allow re-enabling message after disabling
From: Joel Granados
Date: Mon Mar 17 2025 - 15:42:23 EST
On Fri, Mar 14, 2025 at 11:48:43AM +0100, Christian Brauner wrote:
> On Thu, 13 Mar 2025 16:46:36 +0100, Joel Granados wrote:
> > After writing "4" to /proc/sys/vm/drop_caches there was no way to
> > re-enable the drop_caches kernel message. By removing the "or" logic for
> > the stfu variable in drop_cache_sysctl_handler, it is now possible to
> > toggle the message on and off by setting the 4th bit in
> > /proc/sys/vm/drop_caches.
> >
> >
> > [...]
>
> Applied to the vfs-6.15.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-6.15.misc branch should appear in linux-next soon.
>
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
>
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
>
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs-6.15.misc
>
> [1/1] drop_caches: Allow re-enabling message after disabling
> https://git.kernel.org/vfs/vfs/c/66c4cbae77e2
FYI, Sent out a V2 after discussion in [1]
[1]: https://lore.kernel.org/20250216100514.3948-1-rwchen404@xxxxxxxxx
--
Joel Granados