Re: [PATCH v4 1/2] tracing: Fix a compilation error without CONFIG_MODULES

[Google]

On Fri, 14 Mar 2025 05:42:57 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Fri, 14 Mar 2025 01:26:51 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
> 
> > @@ -6040,9 +6042,10 @@ static void update_last_data(struct trace_array *tr)
> >  		memset(tscratch->entries, 0,
> >  		       flex_array_size(tscratch, entries, tscratch->nr_entries));
> >  		tscratch->nr_entries = 0;
> > -
> > +#ifdef CONFIG_MODULES
> >  		guard(mutex)(&scratch_mutex);
> >  		module_for_each_mod(save_mod, tr);
> > +#endif
> >  	}
> 
> Hmm, I think the real fix for this would be to make
> module_for_each_mod() a nop when modules are not configured.

Yeah, but in this case, save_mod() need to be removed too[*]. Or is it
better to make save_mod() a nop too?

[*] https://lore.kernel.org/oe-kbuild-all/202503142045.0sE1neLa-lkp@xxxxxxxxx/

Thank you,

> 
> -- Steve
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>