Re: [PATCH v2 1/1] scsi: ufs: core: add device level exception support

[Peter Wang (王信友)]

On Fri, 2025-03-14 at 15:55 -0700, Bao D. Nguyen wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> The ufs device JEDEC specification version 4.1 adds support for the
> device level exception events. To support this new device level
> exception feature, expose two new sysfs nodes below to provide
> the user space access to the device level exception information.
> /sys/bus/platform/drivers/ufshcd/*/device_lvl_exception_count
> /sys/bus/platform/drivers/ufshcd/*/device_lvl_exception_id
> 
> The device_lvl_exception_count sysfs node reports the number of
> device level exceptions that have occurred since the last time
> this variable is reset. Writing a value of 0 will reset it.
> The device_lvl_exception_id reports the exception ID which is the
> qDeviceLevelExceptionID attribute of the device JEDEC specifications
> version 4.1 and later. The user space application can query these
> sysfs nodes to get more information about the device level exception.
> 
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@xxxxxxxxxxx>
> ---
> Changes in v2:
> 1. Addressed Mani's comments:
>    - Update the documentation of dev_lvl_exception_count to
> read/write.
>    - Rephrase the description of the Documentation and commit text.
>    - Remove the export of ufshcd_read_device_lvl_exception_id().
> 2. Addressed Bart's comments:
>    - Rename dev_lvl_exception sysfs node to dev_lvl_exception_count.
>    - Update the documentation of the sysfs nodes.
>    - Skip comment about sysfs_notify() being used in interrupt
>      context because Avri already addressed it.
> ---
> 
> 

Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>