Re: [tip: objtool/core] objtool: Add CONFIG_OBJTOOL_WERROR

From: Josh Poimboeuf
Date: Tue Mar 18 2025 - 00:59:10 EST


On Mon, Mar 17, 2025 at 05:27:32PM -0700, Josh Poimboeuf wrote:
> On Mon, Mar 17, 2025 at 11:07:23AM +0000, tip-bot2 for Josh Poimboeuf wrote:
> > The following commit has been merged into the objtool/core branch of tip:
> >
> > Commit-ID: 36799069b48198e5ce92d99310060c4aecb4b3e3
> > Gitweb: https://git.kernel.org/tip/36799069b48198e5ce92d99310060c4aecb4b3e3
> > Author: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > AuthorDate: Fri, 14 Mar 2025 12:29:11 -07:00
> > Committer: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > CommitterDate: Mon, 17 Mar 2025 11:51:44 +01:00
> >
> > objtool: Add CONFIG_OBJTOOL_WERROR
> >
> > Objtool warnings can be indicative of crashes, broken live patching, or
> > even boot failures. Ignoring them is not recommended.
> >
> > Add CONFIG_OBJTOOL_WERROR to upgrade objtool warnings to errors by
> > enabling the objtool --Werror option. Also set --backtrace to print the
> > branches leading up to the warning, which can help considerably when
> > debugging certain warnings.
> >
> > To avoid breaking bots too badly for now, make it the default for real
> > world builds only (!COMPILE_TEST).
>
> This last paragraph is no longer accurate, looks like it was changed to
> be off by default.

Also, given all the review comments, should I post a v2 set to replace
the merged commits?

--
Josh