Re: [PATCH 1/3] dt-bindings: clock: renesas: Fix description section

From: Pavel Machek
Date: Tue Mar 18 2025 - 04:22:12 EST


Hi!

> On Mon, 17 Mar 2025 at 09:32, Tommaso Merciai
> <tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
> > Remove not needed "and" into description section.
> >
> > Reported-by: Pavel Machek <pavel@xxxxxxx>
> > Closes: https://lore.kernel.org/cip-dev/Z9P%2F51qOlq2B46FK@xxxxxxxxxx/
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> > +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> > @@ -12,7 +12,7 @@ maintainers:
> > description:
> > On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator) handles
> > generation and control of clock signals for the IP modules, generation and
> > - control of resets, and control over booting, low power consumption and power
> > + control of resets, control over booting, low power consumption and power
> > supply domains.
> >
> > properties:
>
> I think the original is fine. When emphasizing the structure:
>
> The CPG handles:
> A. generation and control of clock signals for the IP modules,
> B. generation and control of resets, and
> C. control over booting, low power consumption and power supply domains.
>
> i.e. the "and" is part of the typical "A, B, and C" construct?

Well, it is still horid sentence. What about making it into list, as
you did?

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature