Re: [PATCH v4] fs/proc/page: Refactoring to reduce code duplication.

From: David Hildenbrand
Date: Tue Mar 18 2025 - 04:45:52 EST


On 18.03.25 07:32, Liu Ye wrote:
From: Liu Ye <liuye@xxxxxxxxxx>

The function kpageflags_read and kpagecgroup_read is quite similar
to kpagecount_read. Consider refactoring common code into a helper
function to reduce code duplication.

Signed-off-by: Liu Ye <liuye@xxxxxxxxxx>

---
V4 : Update code remake patch.
V3 : Add a stub for page_cgroup_ino and remove the #ifdef CONFIG_MEMCG.
V2 : Use an enumeration to indicate the operation to be performed
to avoid passing functions.
---

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

Thanks!

--
Cheers,

David / dhildenb