Re: [PATCH 2/2] arm64: dts: qcom: qcs615: add QCrypto nodes

[Abhinaba Rakshit]

On Tue, Feb 25, 2025 at 02:52:36PM +0100, Konrad Dybcio wrote:
> On 24.02.2025 11:04 AM, Abhinaba Rakshit wrote:
> > Add the QCE and Crypto BAM DMA nodes.
> > 
> > Signed-off-by: Abhinaba Rakshit <quic_arakshit@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/qcs615.dtsi | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > index f4abfad474ea62dea13d05eb874530947e1e8d3e..25e98d20ec1d941f0b45cc3d94f298065c9a5566 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > @@ -1114,6 +1114,31 @@ ufs_mem_phy: phy@1d87000 {
> >  			status = "disabled";
> >  		};
> >  
> > +		cryptobam: dma-controller@1dc4000 {
> > +			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> > +			reg = <0x0 0x01dc4000 0x0 0x24000>;
> > +			interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
> > +			#dma-cells = <1>;
> > +			qcom,ee = <0>;
> > +			qcom,controlled-remotely;
> > +			num-channels = <16>;
> > +			qcom,num-ees = <4>;
> > +			iommus = <&apps_smmu 0x0104 0x0011>,
> > +				 <&apps_smmu 0x0114 0x0011>;
> 
> (0x0114 & ~ 0x0011) == (0x0104 & ~0x0011), try dropping the second entry
> here and below and see if things still work
> 

With dropping the second entry, as well qcrypto is still functional,
Will update in the patch v2

> > +		};
> > +
> > +		crypto: crypto@1dfa000 {
> > +			compatible = "qcom,qcs615-qce", "qcom,sm8150-qce", "qcom,qce";
> > +			reg = <0x0 0x01dfa000 0x0 0x6000>;
> > +			dmas = <&cryptobam 4>, <&cryptobam 5>;
> > +			dma-names = "rx", "tx";
> > +			iommus = <&apps_smmu 0x0104 0x0011>,
> > +				 <&apps_smmu 0x0114 0x0011>;
> > +			interconnects = <&aggre1_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS
> > +					&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
> 
> Please align the '&'s

Will update in patch v2

> 
> Konrad