Re: [PATCH 5/5] x86/cpuid: Use u32 in instead of uint32_t in <asm/cpuid/api.h>
From: Borislav Petkov
Date: Tue Mar 18 2025 - 05:38:33 EST
On Tue, Mar 18, 2025 at 09:34:41AM +0100, Ingo Molnar wrote:
> That's a stupid rule, I don't know where it came from, and I never
> enforced it. It's not in Documentation/process/coding-style.rst.
I believe tglx came up with it - section "Changelog" in
Documentation/process/maintainer-tip.rst
Read the examples there.
And you and I have had this conversation already on IRC. I happen to agree
with him that "we" is ambiguous - with all those companies submitting patches
you don't know who's "we" interests are being taken care of.
And if you formulate your commit message in impersonal tone, it reads a lot
clearer. It is simply a lot better this way.
Is it a hard rule? Ofc not - there are exceptions to that rule depending on
the context. But most if the time and IMNSVHO, impersonal formulations read
a lot better and clearer.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette