Re: [PATCH] virtio: console: Make resizing compliant with virtio spec
From: Amit Shah
Date: Tue Mar 18 2025 - 05:52:36 EST
On Mon, 2025-03-10 at 14:04 +0100, Maximilian Immanuel Brandtner wrote:
[...]
> Just to make sure that everyone here is one the same page there is
> indeed a difference between the ordering of the control resize
> message
> and the kernel implementation; however as this bug has been around
> for
> ~15 years the spec should be changed instead, right?
>
> I would like to get a clear ACK of the issue, as I would like to
> reference this discussion when creating a bug-report on the virtio-
> spec
> github.
I'm afraid you haven't understood the difference between a control
message for an individual port, and the config space for the entire
device. Please re-read my post earlier in the thread, and follow the
code. There's no divergence in the implementation and the spec, and
there's nothing to fix. If anything, there may be a chance to add to
the spec the order for the control message - though I don't think
there's a strong need to.
Amit