Re: [PATCH v3 14/18] nvmet-fc: take tgtport reference only once

From: Hannes Reinecke
Date: Tue Mar 18 2025 - 07:19:55 EST


On 3/18/25 11:40, Daniel Wagner wrote:
The reference counting code can be simplified. Instead taking a tgtport
refrerence at the beginning of nvmet_fc_alloc_hostport and put it back
if not a new hostport object is allocated, only take it when a new
hostport object is allocated.

Signed-off-by: Daniel Wagner <wagi@xxxxxxxxxx>
---
drivers/nvme/target/fc.c | 24 +++++++++---------------
1 file changed, 9 insertions(+), 15 deletions(-)

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich