Re: [PATCH v7 7/7] Documentation: Add sysfs documentation for PSCRR reboot reason tracking

[Matti Vaittinen]

On 18/03/2025 13:24, Oleksij Rempel wrote:
> On Tue, Mar 18, 2025 at 01:17:38PM +0200, Matti Vaittinen wrote:
> > On 18/03/2025 11:47, Oleksij Rempel wrote:

> > A side note which you can consider if you feel like:
> > This, as far as I understand, will also make the ABI out of this. So,
> > perhaps there should be comments in enum psc_reason and the defines in
> > Defined in 'include/linux/reboot.h' that they are part of an ABI, and must
> > not be changed? I suppose user-space tools may get unhappy if these values
> > change between the kernel versions.
>
> Yes, there is already: "Importantly, the order of these values **must
> remain stable**, as bootloaders, user-space tools, or post-mortem
> investigation utilities may rely on their numerical representation for
> consistent behavior." :)

Just noticed this. My bad, I did reviewing in wrong order :)

> > Reviewed-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> >
> > Yours,
> > 	-- Matti