Re: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset()

From: Mark Brown
Date: Tue Mar 18 2025 - 08:49:25 EST


On Tue, Mar 18, 2025 at 03:36:54AM -0700, Breno Leitao wrote:

> My assumptions, now:

> 1) This controller doesn't have _RST ACPI method by design.

> 2) It is OK to not have reset methods (!?)

Well, that's not clear to me. It seems likely to work a lot of the time
on probe but I don't know how well it handles a warm reboot for example.
Like I say the error handling case seems more likely to be at least less
effective without a reset controller so it'd be worth logging. In the
DT the reset controller is a required property which suggests the driver
might be assuming it's got the hardware into a known state.

Attachment: signature.asc
Description: PGP signature