Re: [PATCH] regulator: s5m8767: Convert to GPIO descriptors

[Krzysztof Kozlowski]

On 18/03/2025 13:38, Peng Fan wrote:
>> Also the commit message doesn't tell anything about the existing DTS
>> files.
>> Do we have this device described in any in the kernel? Do we have any
>> googled examples? Why I'm asking because often the issue is the
>> incorrect setting of the polarity, which needs to be carefully checked,
>> esp. for the voltage regulators case.
> 
> 
> Under arch/arm/boot/dts/samsung/, a few dtsi files have the property 
> with results from output of
> `grep "s5m8767" ./arch/arm/boot/dts/samsung/ -rn | grep gpios`
> 
> Exynos5250-spring.dts uses GPIO_ACTIVE_LOW.
> Others use GPIO_ACTIVE_HIGH.
> 
These are old devices and not many people are actually providing tests,
so you need to preserve existing ABI. IOW, if previously GPIO flags were
ignored, meaning "1" is ACTIVE_HIGH, then you must preserve this behavior.

Best regards,
Krzysztof