Re: [PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header

[Huacai Chen]

Hi, Greg,

On Tue, Mar 18, 2025 at 9:25 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Mar 18, 2025 at 07:01:22PM +0800, Huacai Chen wrote:
> > From: Jan Stancek <jstancek@xxxxxxxxxx>
> >
> > commit 300e6d4116f956b035281ec94297dc4dc8d4e1d3 upstream.
> >
> > Couple error handling helpers are repeated in both tools, so
> > move them to a common header.
> >
> > Signed-off-by: Jan Stancek <jstancek@xxxxxxxxxx>
> > Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> > Tested-by: R Nageswara Sastry <rnsastry@xxxxxxxxxxxxx>
> > Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
> > Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > ---
>
> Is this "v2" as well?  the threading is all confusing here.  This is
> what my inbox looks like right now:
Yes, this is also V2, I'm very sorry to confuse you.

Huacai

>
>
>   32 N T Mar 18 Huacai Chen     (2.9K) [PATCH 6.1&6.6 V2 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0
>   33 N T Mar 18 Huacai Chen     (7.9K) ├─>[PATCH 6.1&6.6 V2 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3
>   34 N T Mar 18 Huacai Chen     (3.4K) ├─>[PATCH 6.1&6.6 V2 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line()
>   35 N T Mar 18 Huacai Chen     (4.8K) └─>[PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header
>   46 N T Mar 18 Huacai Chen     (2.9K) [PATCH 6.1&6.6 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0
>   47 N T Mar 18 Huacai Chen     (3.3K) ├─>[PATCH 6.1&6.6 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line()
>   48 N T Mar 18 Huacai Chen     (4.8K) ├─>[PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header
>   50 N T Mar 18 Huacai Chen     (7.8K) └─>[PATCH 6.1&6.6 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3
>
> What would you do if you saw that?
>
> greg k-h