Re: [PATCH v1 1/1] i3c: master: svc: Fix i3c_master_get_free_addr return check

From: Qasim Ijaz
Date: Tue Mar 18 2025 - 10:53:47 EST


On Mon, Mar 17, 2025 at 11:46:29PM +0100, Alexandre Belloni wrote:
> On Mon, 10 Mar 2025 10:33:04 +0800, Stanley Chu wrote:
> > The return value of i3c_master_get_free_addr is assigned to a variable
> > with wrong type, so it can't be negative. Use a signed integer for the
> > return value. If the value is negative, break the process and propagate
> > the error code.
> >
> > This commit also fixes the uninitialized symbol 'dyn_addr', reported
> > by Smatch static checker.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] i3c: master: svc: Fix i3c_master_get_free_addr return check
> https://git.kernel.org/abelloni/c/d6cb667b8e15
>
> Best regards,
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Hi Alexandre,

I sent a fix for this issue on the 9th March, which is before the patch
Stanley sent which was sent on the 10th March.

You can view my orignal patch here:

https://lore.kernel.org/all/20250309164314.15039-1-qasdev00@xxxxxxxxx/

Thanks
Qasim
>
> --
> linux-i3c mailing list
> linux-i3c@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-i3c