Re: [PATCH v3 2/2] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
From: Konrad Dybcio
Date: Tue Mar 18 2025 - 11:55:44 EST
On 3/18/25 10:33 AM, Stone Zhang wrote:
> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> of the WCN6855 and assigning its LDO power outputs to the existing
> WiFi module.
>
> Signed-off-by: Stone Zhang <quic_stonez@xxxxxxxxxxx>
> ---
This change looks good generally, but please align the various stylistic
things, like property order in the nodes you add with x1e80100-crd.dtsi
I also see that board-2.bin doesn't contain the variant string you've
suggested ([1] @ commit 646e008ec53a8bb9ae16ebf98a65b29eaefd6da4)
Konrad
[1] https://git.codelinaro.org/clo/ath-firmware/ath11k-firmware/-/blob/main/WCN6855/hw2.0/board-2.bin?ref_type=heads