Re: [PATCH v2] dt-bindings: timer: Add SiFive CLINT2

[Rob Herring]

On Sun, Mar 16, 2025 at 9:36 PM Nick Hu <nick.hu@xxxxxxxxxx> wrote:
>
> Hi Rob

Please don't top post.

> Sorry, I thought I had replied to the mailing list, but it looks like
> I only sent it to Conor.
>
> The control of sifive,clint2 differs from that of sifive,clint0,
> making them incompatible.

The answer belongs in the patch, not just in a reply. Assume we've
forgotten everything said in the prior version because we likely have,
so you don't want to get the same questions again.

>
> On Sat, Mar 15, 2025 at 7:25 AM Rob Herring <robh@xxxxxxxxxx> wrote:
> >
> > On Fri, Mar 14, 2025 at 04:12:54PM +0800, Nick Hu wrote:
> > > Add compatible string and property for the SiFive CLINT v2.
> >
> > Conor asked about being backwards compatible with v1. Please say why it
> > isn't here.
> >
> > >
> > > Signed-off-by: Nick Hu <nick.hu@xxxxxxxxxx>
> > > Reviewed-by: Samuel Holland <samuel.holland@xxxxxxxxxx>
> > > ---
> > > - v2 changes:
> > >   - Don't allow sifive,clint2 by itself. Add '-{}' to the first entry
> > >   - Mark the sifive,fine-ctr-bits as the required property when
> > >     the compatible includes the sifive,clint2
> > >
> > >  .../bindings/timer/sifive,clint.yaml          | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > index 76d83aea4e2b..4b9dad11c1e9 100644
> > > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > @@ -36,6 +36,10 @@ properties:
> > >                - starfive,jh7110-clint   # StarFive JH7110
> > >                - starfive,jh8100-clint   # StarFive JH8100
> > >            - const: sifive,clint0        # SiFive CLINT v0 IP block
> > > +      - items:
> > > +          - {}
> > > +          - const: sifive,clint2        # SiFive CLINT v2 IP block
> > > +        description: SiFive CLINT v2 is the HRT that supports the Zicntr
> > >        - items:
> > >            - enum:
> > >                - allwinner,sun20i-d1-clint
> > > @@ -62,6 +66,22 @@ properties:
> > >      minItems: 1
> > >      maxItems: 4095
> > >
> > > +  sifive,fine-ctr-bits:
> > > +    maximum: 15
> > > +    description: The width in bits of the fine counter.
> > > +
> > > +if:
> > > +  properties:
> > > +    compatible:
> > > +      contains:
> > > +        const: sifive,clint2
> > > +then:
> > > +  required:
> > > +    - sifive,fine-ctr-bits
> > > +else:
> > > +  properties:
> > > +    sifive,fine-ctr-bits: false
> > > +
> > >  additionalProperties: false
> > >
> > >  required:
> > > --
> > > 2.17.1
> > >
>
> Best Regards,
> Nick
>