Re: [PATCH v2 1/4] KVM: TDX: Fix definition of tdx_guest_nr_guest_keyids()
From: Verma, Vishal L
Date: Tue Mar 18 2025 - 12:37:57 EST
On Tue, 2025-03-18 at 15:33 +0000, Edgecombe, Rick P wrote:
> On Tue, 2025-03-18 at 00:35 -0600, Vishal Verma wrote:
> > When CONFIG_INTEL_TDX_HOST=n, the above definition produced an
> > unused-function warning with gcc.
> >
> > error: ‘tdx_get_nr_guest_keyids’ defined but not used [-
> > Werror=unused-function]
> > 198 | static u32 tdx_get_nr_guest_keyids(void) { return 0; }
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> >
> > Make the definition 'inline' so that in the config disabled case,
> > the
> > whole thing can be optimized away.
>
> This looks to be fixed in the current kvm-coco-queue. Can you double
> check?
>
>
Indeed it is, I will drop it for the next revision.