Re: [PATCH] btrfs: remove EXTENT_BUFFER_IN_TREE flag

[Daniel Vacek]

On Tue, 18 Mar 2025 at 16:45, David Sterba <dsterba@xxxxxxx> wrote:
>
> On Tue, Mar 18, 2025 at 10:54:38AM +0100, Daniel Vacek wrote:
> > This flag is set after inserting the eb to the buffer tree and cleared on
> > it's removal. But it does not bring any added value. Just kill it for good.
>
> Would be good to add the reference to commit that added the bit,
> 34b41acec1ccc0 ("Btrfs: use a bit to track if we're in the radix tree")
> and wanted to make use of it, faa2dbf004e89e ("Btrfs: add sanity tests
> for new qgroup accounting code"). And both are 10+ years old.

Right, I could have checked the history.

Though honestly from the diff of these two commits I don't see any
valid usage of this flag either. Must have been somewhere in the
context or I'm missing something.

> > Signed-off-by: Daniel Vacek <neelx@xxxxxxxx>
>
> Reviewed-by: David Sterba <dsterba@xxxxxxxx>