Re: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset()

[Breno Leitao]

On Tue, Mar 18, 2025 at 06:35:18PM +0000, Mark Brown wrote:

> > Do you want me to resend those two separately, or, is this thread
> > enough?
> 
> Please resend.  I think I was anticipating a new version of this patch
> with a clarified changelog and some rework to tone down the logging
> that's generated similar to the other patches rather than just silently
> ignoring the lack of a reset controller.

Sorry, I am more than happy to change it the way you prefer, but, the
warnings coming from "device reset failed" are already printed once:

Here are the instances of calls to device_reset(), all of them with
`dev_warn_once()`:

	if (device_reset(tqspi->dev) < 0)
		dev_warn_once(tqspi->dev, "device reset failed\n");

and

	/* Reset controller if timeout happens */
	if (device_reset(tqspi->dev) < 0)
		dev_warn_once(tqspi->dev,
			"device reset failed\n");


So, this one is not very noisy. Should I change anything?

On the other side, I see some other messages that are very noise, being
displayed at every message that is failing to go through. They are:

           spi_master spi0: failed to transfer one message from queue
           spi_master spi0: noqueue transfer failed

I will rate limit those as well.

Thanks for your direction,
--breno