Re: [PATCH net-next] netfilter: xtables: Use strscpy() instead of strscpy_pad()
From: Florian Westphal
Date: Tue Mar 18 2025 - 16:14:43 EST
Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
> kzalloc() already zero-initializes the destination buffer, making
> strscpy() sufficient for safely copying the name. The additional NUL-
> padding performed by strscpy_pad() is unnecessary.
>
> The size parameter is optional, and strscpy() automatically determines
> the size of the destination buffer using sizeof() if the argument is
> omitted. This makes the explicit sizeof() call unnecessary; remove it.
>
> No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
Reviewed-by: Florian Westphal <fw@xxxxxxxxx>