Re: [PATCH 2/3] firmware: exynos-acpm: silence EPROBE_DEFER error on boot
From: André Draszik
Date: Tue Mar 18 2025 - 16:48:24 EST
On Mon, 2025-03-17 at 10:48 +0000, Tudor Ambarus wrote:
>
>
> On 3/17/25 10:26 AM, Tudor Ambarus wrote:
> >
> >
> > On 3/14/25 4:40 PM, André Draszik wrote:
> > > This driver emits error messages when client drivers are trying to get
> > > an interface handle to this driver here before this driver has
> > > completed _probe().
> > >
> > > Given this driver returns -EPROBE_DEFER in that case, this is not an
> > > error and shouldn't be emitted to the log, so just remove them.
> > >
> > > Fixes: a88927b534ba ("firmware: add Exynos ACPM protocol driver")
> > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> >
> > Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
>
> I see you kept the error message though for of_find_device_by_node()
> failure. You either get rid of that too, or maybe transform all to dev_dbg?
Thanks Tudor. Seems I missed that, I'll remove it, too.
Cheers,
A.