Re: [PATCH v6 01/10] hyperv: Log hypercall status codes as strings
From: Easwar Hariharan
Date: Wed Mar 19 2025 - 00:17:58 EST
On 3/14/2025 12:28 PM, Nuno Das Neves wrote:
> Introduce hv_status_printk() macros as a convenience to log hypercall
> errors, formatting them with the status code (HV_STATUS_*) as a raw hex
> value and also as a string, which saves some time while debugging.
>
> Create a table of HV_STATUS_ codes with strings and mapped errnos, and
> use it for hv_result_to_string() and hv_result_to_errno().
>
> Use the new hv_status_printk()s in hv_proc.c, hyperv-iommu.c, and
> irqdomain.c hypercalls to aid debugging in the root partition.
>
> Signed-off-by: Nuno Das Neves <nunodasneves@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Stanislav Kinsburskii <skinsburskii@xxxxxxxxxxxxxxxxxxx>
> ---
> arch/x86/hyperv/irqdomain.c | 6 +-
> drivers/hv/hv_common.c | 129 ++++++++++++++++++++++++---------
> drivers/hv/hv_proc.c | 10 +--
> drivers/iommu/hyperv-iommu.c | 4 +-
> include/asm-generic/mshyperv.h | 13 ++++
> 5 files changed, 118 insertions(+), 44 deletions(-)
>
Looks good to me.
Reviewed-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>