Re: [PATCH] HID: appletb-kbd: Replace msecs_to_jiffies with secs_to_jiffies for timer settings

[Krzysztof Kozlowski]

On 19/03/2025 03:12, xie.ludan@xxxxxxxxxx wrote:
> From: Peng Jiang <jiang.peng9@xxxxxxxxxx>
> 
> The variables `appletb_tb_idle_timeout` and `appletb_tb_dim_timeout`
> are already defined in seconds, so using `secs_to_jiffies` directly
> makes the code more readable and consistent with the units used.
> 
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:

Why do you need to paste here contentx of existing cocci script? It's
already mainlined, no?

> 
> @depends on patch@
> expression E;
> @@
> 
> -msecs_to_jiffies
> +secs_to_jiffies
> (E
> - * \( 1000 \| MSEC_PER_SEC \)
> )
> 
> Signed-off-by: Peng Jiang <jiang.peng9@xxxxxxxxxx>
> Signed-off-by: XieLudan <xie.ludan@xxxxxxxxxx>
Same comment as before. Did you respond to previous feedbacks? No.

Best regards,
Krzysztof