Re: [PATCH -next] ext4: correct the error handle in ext4_fallocate()
From: Baokun Li
Date: Wed Mar 19 2025 - 03:30:54 EST
On 2025/3/19 10:35, Zhang Yi wrote:
From: Zhang Yi <yi.zhang@xxxxxxxxxx>
The error out label of file_modified() should be out_inode_lock in
ext4_fallocate().
Fixes: 2890e5e0f49e ("ext4: move out common parts into ext4_fallocate()")
Reported-by: Baokun Li <libaokun1@xxxxxxxxxx>
Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx>
---
Looks good. Feel free to add:
Reviewed-by: Baokun Li <libaokun1@xxxxxxxxxx>
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 1b028be19193..dcc49df190ed 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4744,7 +4744,7 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
ret = file_modified(file);
if (ret)
- return ret;
+ goto out_inode_lock;
if ((mode & FALLOC_FL_MODE_MASK) == FALLOC_FL_ALLOCATE_RANGE) {
ret = ext4_do_fallocate(file, offset, len, mode);