Re: [PATCH v4 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property

From: Krzysztof Kozlowski
Date: Wed Mar 19 2025 - 04:42:49 EST


On Tue, Mar 18, 2025 at 08:45:54PM +0100, Sergio Perez wrote:

Your threading is completely broken.

Read my last message - I gave you clear instructions which you did not
follow. Why?

>
> + reset-gpios:
> + description: GPIO connected to the sensor's reset line (active low)

"Active low reset line". No point to say that GPIO is a "GPIO connected
to the...", because it cannot be anything else.

> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -39,6 +43,7 @@ examples:
> light-sensor@23 {
> compatible = "rohm,bh1750";
> reg = <0x23>;
> + reset-gpios = <&gpio2 17 0>;

1. Include header and use proper defines
2. And then you will see that it is not active low, like you claim in
description...

> };
> };
>
> --
> 2.43.0
>