Re: [PATCH v2 1/2] dt-bindings: hwmon: amc6821: add PWM polarity

[Francesco Dolcini]

Hello Rob and all,

On Wed, Feb 26, 2025 at 02:58:06PM +0100, Francesco Dolcini wrote:
> On Wed, Feb 26, 2025 at 07:49:22AM -0600, Rob Herring wrote:
> > On Mon, Feb 24, 2025 at 07:08:00PM +0100, Francesco Dolcini wrote:
> > > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> > > 
> > > Add property to describe the PWM-Out pin polarity.
> > 
> > Why doesn't the invert support in the pwm binding work for you? Yes, I 
> > read the discussion, but don't remember the conclusion and you need to 
> > justify it here.
> 
> This chip is not a PWM controller, it is a FAN controller.
> 
> The HW has a PWM pin output that is used to control the fan, but the
> device is not modelled as a PWM controller (correctly, given that is not
> such a device) and the OS does not control the PWM, the chip reads the
> temperature and decide the PWM duty cycle accordingly in an autonomous
> way.

Can you advise on how to move this forward? Is my explanation good
enough or some more clarification is needed? Should I send a v3
incorporating such a comment into the commit message? Anything else?

Thanks,
Francesco