Re: [PATCH] sched/topology: Fix sched_is_eas_possible() prints

[Vincent Guittot]

On Wed, 19 Mar 2025 at 11:59, Christian Loehle <christian.loehle@xxxxxxx> wrote:
>
> Add the missing newline on two failure prints to ensure EAS abort
> reasons don't go missing.

Would be good to have a Fixes tag

Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>

>
> Signed-off-by: Christian Loehle <christian.loehle@xxxxxxx>
> ---
>  kernel/sched/topology.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index c49aea8c1025..18e804b416f5 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -245,7 +245,7 @@ static bool sched_is_eas_possible(const struct cpumask *cpu_mask)
>
>         if (!arch_scale_freq_invariant()) {
>                 if (sched_debug()) {
> -                       pr_info("rd %*pbl: Checking EAS: frequency-invariant load tracking not yet supported",
> +                       pr_info("rd %*pbl: Checking EAS: frequency-invariant load tracking not yet supported\n",
>                                 cpumask_pr_args(cpu_mask));
>                 }
>                 return false;
> @@ -256,7 +256,7 @@ static bool sched_is_eas_possible(const struct cpumask *cpu_mask)
>                 policy = cpufreq_cpu_get(i);
>                 if (!policy) {
>                         if (sched_debug()) {
> -                               pr_info("rd %*pbl: Checking EAS, cpufreq policy not set for CPU: %d",
> +                               pr_info("rd %*pbl: Checking EAS, cpufreq policy not set for CPU: %d\n",
>                                         cpumask_pr_args(cpu_mask), i);
>                         }
>                         return false;
> --
> 2.34.1